Early career

Badir was recognized early on as a valuable prospect, and played for the youth clubs Hapoel Kafr Qasim and Hapoel Petah Tikva, and later was given a spot on the second team's Premier League squad. Badir played for Petach Tikva for seven consecutive seasons (1992–1997) and scored 19 goals.

Wimbledon

During Badir's time at Wimbledon he scored one league goal against Manchester United at Old Trafford.^[3] However, other than this he did not make a major impact in his time with the club, making only 21 team appearances in total.

Maccabi Haifa

Badir returned to Israel to Maccabi Haifa in 2000–01 at the beginning of the Avram Grant era. Grant created one of the most gifted teams in the history of Israeli football. With Badir, Haifa won four championships, failing only once, in 2002–03 when Maccabi Tel Aviv won the title.

Hapoel Tel Aviv

In 2005, while Haifa began a major campaign to revamp the squad with South American players such ad Gustavo Boccoli and Roberto Colautti, Badir signed with Hapoel Tel Aviv. He became a major part of their 2005–06 season when they were runners-up to his former team and State Cup winners. He was awarded the captaincy of the team and held it until his retirement.

On 26 August 2013, in Bloomfield Stadium, the club and its fans made a thankful standing ovation in honour of Badir's last appearance with Hapoel Tel Aviv before formally retiring.